r14381: Kill structs.h

source/include/includes.h

@@ -111,7 +111,6 @@ enum brl_type {
 #include "talloc/talloc.h"
 #include "core.h"
 #include "charset/charset.h"
-#include "structs.h"
 #include "util/util.h"
 #include "param/param.h"
 #include "libcli/util/nterr.h"

source/include/structs.h

@@ -1,32 +0,0 @@
-/* 
-   Unix SMB/CIFS implementation.
-
-   Copyright (C) Andrew Tridgell 2004
-   
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
-   (at your option) any later version.
-   
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-   
-   You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-*/
-
-/*
-  this file contains pre-declarations of private structures to avoid the
-  "scope is only this definition or declaration" warning
-*/
-
-struct asn1_data;
-struct smbsrv_tcon;
-struct smbsrv_connection;
-struct param_context;
-struct smbcli_tree;
-struct smb2_tree;
-struct socket_address;

source/lib/samba3/samba3.h

@@ -23,7 +23,7 @@
 
 #include "librpc/gen_ndr/security.h"
 #include "librpc/gen_ndr/samr.h"
-#include "param/generic.h"
+#include "param/param.h"
 
 struct samba3_samaccount {
 	uint32_t logon_time,

source/lib/util/util.h

@@ -30,6 +30,8 @@
  */
 
 struct substitute_context;
+struct asn1_data;
+struct smbsrv_tcon;
 
 #include "util/xfile.h"
 #include "util/debug.h"

source/librpc/rpc/dcerpc.h

@@ -249,6 +249,10 @@ struct rpc_request {
 struct epm_tower;
 struct epm_floor;
 
+struct smbcli_tree;
+struct smb2_tree;
+struct socket_address;
+
 #include "librpc/rpc/dcerpc_proto.h"
 
 #endif /* __DCERPC_H__ */

source/param/config.mk

@@ -4,7 +4,7 @@ OBJ_FILES = loadparm.o \
 			generic.o \
 			../lib/version.o
 REQUIRED_SUBSYSTEMS = LIBBASIC 
-PRIVATE_PROTO_HEADER = param.h
+PRIVATE_PROTO_HEADER = proto.h
 
 PATH_FLAGS = -DCONFIGFILE=\"$(CONFIGFILE)\" \
 	 -DBINDIR=\"$(BINDIR)\" -DLMHOSTSFILE=\"$(LMHOSTSFILE)\" \

source/param/generic.c

@@ -19,7 +19,7 @@
 
 #include "includes.h"
 #include "dlinklist.h"
-#include "param/generic.h"
+#include "param/param.h"
 #include "system/filesys.h"
 
 struct param_section *param_get_section(struct param_context *ctx, const char *name)

source/param/param.h

@@ -18,8 +18,8 @@
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#ifndef _PARAM_GENERIC_H /* _PARAM_GENERIC_H */
-#define _PARAM_GENERIC_H 
+#ifndef _PARAM_H /* _PARAM_H */
+#define _PARAM_H 
 
 struct param_context {
 	struct param_section *sections;
@@ -38,4 +38,9 @@ struct param_section {
 	struct param *parameters;
 };
 
-#endif /* _PARAM_GENERIC_H */
+struct param_context;
+struct smbsrv_connection;
+
+#include "param/proto.h"
+
+#endif /* _PARAM_H */

source/scripting/ejs/smbcalls_param.c

@@ -23,7 +23,7 @@
 #include "includes.h"
 #include "scripting/ejs/smbcalls.h"
 #include "lib/appweb/ejs/ejs.h"
-#include "param/generic.h"
+#include "param/param.h"
 
 /*
   get parameter