sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-09 09:57:48 +03:00
Code

smbd: remove initial stat() EACCES handling from unix_convert()

Browse Source 
This was added by bd90ca6f00b (my bad) but it breaks filesystems with NFS4
permissions.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 23 19:50:38 UTC 2020 on sn-devel-184
This commit is contained in:
Ralph Boehme 2020-04-23 10:48:51 +02:00 committed by Jeremy Allison
parent fdfc480a56
commit 205acab580
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source3/smbd/filename.c
View File

@ -700,17 +700,12 @@ NTSTATUS unix_convert(TALLOC_CTX *ctx,
/* Stat failed - ensure we don't use it. */ /* Stat failed - ensure we don't use it. */
SET_STAT_INVALID(smb_fname->st); SET_STAT_INVALID(smb_fname->st);
if (errno == EACCES) { /*
/* * Note: we must continue processing a path if we get EACCES
* Early exit on access denied. Walking * from stat. With NFS4 permissions the file might be lacking
* the path won't fix that. * READ_ATTR, but if the parent has LIST permissions we can
*/ * resolve the path in the path traversal loop down below.
DBG_DEBUG("stat [%s]: %s\n", */
smb_fname_str_dbg(smb_fname),
strerror(errno));
status = NT_STATUS_ACCESS_DENIED;
goto fail;
}
if (errno == ENOENT) { if (errno == ENOENT) {
/* Optimization when creating a new file - only /* Optimization when creating a new file - only