1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-30 19:42:05 +03:00

tridge the destroyer returns!

prompted by the interpret_security() dead code that Jean-Francois
pointed out I added a make target "finddead" that finds potentially
dead (ie. unused) code. It spat out 304 function names ...

I went through these are deleted many of them, making others static
(finddead also reports functions that are used only in the local
file).

in doing this I have almost certainly deleted some useful code. I may
have even prevented compilation with some compile options. I
apologise. I decided it was better to get rid of this code now and add
back the one or two functions that are needed than to keep all this
baggage.

So, if I have done a bit too much "destroying" then let me know. Keep
the swearing to a minimum :)

One bit I didn't do is the ubibt code. Chris, can you look at that?
Heaps of unused functions there. Can they be made static?
This commit is contained in:
Andrew Tridgell
-
parent 94d63cc382
commit 2204475c87
53 changed files with 467 additions and 2787 deletions

View File

@ -27,20 +27,6 @@
extern int DEBUGLEVEL;
/*******************************************************************
make_wks_q_query_info
********************************************************************/
void make_wks_q_query_info(WKS_Q_QUERY_INFO *q_u,
char *server, uint16 switch_value)
{
DEBUG(5,("make_wks_q_query_info: %d\n", __LINE__));
make_buf_unistr2(&(q_u->uni_srv_name), &(q_u->ptr_srv_name), server);
q_u->switch_value = switch_value;
}
/*******************************************************************
reads or writes a WKS_Q_QUERY_INFO structure.
********************************************************************/
@ -81,7 +67,7 @@ void make_wks_info_100(WKS_INFO_100 *inf,
/*******************************************************************
reads or writes a WKS_INFO_100 structure.
********************************************************************/
void wks_io_wks_info_100(char *desc, WKS_INFO_100 *inf, prs_struct *ps, int depth)
static void wks_io_wks_info_100(char *desc, WKS_INFO_100 *inf, prs_struct *ps, int depth)
{
if (inf == NULL) return;