sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-18 17:57:55 +03:00
Code

a few minor cleanups in the cldap request

Browse Source
This commit is contained in:
Andrew Tridgell -
parent e4cb106d2e
commit 228fc518da
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
source/utils/net_ads_cldap.c
View File

@ -45,7 +45,7 @@ static unsigned pull_len_string(char **ret, const char *p)
unsigned len = *p;
(*ret) = NULL;
if (len == 0) return 1;
(*ret) = strndup(p+1, len);
(*ret) = smb_xstrndup(p+1, len);
return len+1;
}
@ -156,8 +156,9 @@ static int recv_cldap_netlogon(int sock, struct cldap_netlogon_reply *reply)
blob = data_blob(NULL, 8192);
ret = read(sock, blob.data, blob.length);
if (ret <= 0) {
d_printf("no reply to cldap netlogon\n");
d_printf("no reply received to cldap netlogon\n");
return -1;
}
blob.length = ret;
@ -180,6 +181,11 @@ static int recv_cldap_netlogon(int sock, struct cldap_netlogon_reply *reply)
asn1_end_tag(&data);
asn1_end_tag(&data);
if (data.has_error) {
d_printf("Failed to parse cldap reply\n");
return -1;
}
file_save("cldap_reply_core.dat", os3.data, os3.length);
p = os3.data;
@ -207,6 +213,18 @@ static int recv_cldap_netlogon(int sock, struct cldap_netlogon_reply *reply)
}
/*
free a cldap reply packet
*/
static void cldap_reply_free(struct cldap_netlogon_reply *reply)
{
SAFE_FREE(reply->domain);
SAFE_FREE(reply->server_name);
SAFE_FREE(reply->domain_flatname);
SAFE_FREE(reply->server_flatname);
SAFE_FREE(reply->dns_name);
}
/*
do a cldap netlogon query
*/
@ -233,6 +251,10 @@ int ads_cldap_netlogon(ADS_STRUCT *ads)
ret = recv_cldap_netlogon(sock, &reply);
close(sock);
if (ret == -1) {
return -1;
}
d_printf("Version: 0x%x\n", reply.version);
d_printf("GUID: ");
print_guid(&reply.guid);
@ -242,6 +264,8 @@ int ads_cldap_netlogon(ADS_STRUCT *ads)
d_printf("Flatname: %s\n", reply.domain_flatname);
d_printf("Server Name2: %s\n", reply.server_flatname);
d_printf("DNS Name: %s\n", reply.dns_name);
cldap_reply_free(&reply);
return ret;
}