sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Code

s4:dsdb/common: fix major bug in lsa_BinaryString to ldb_val conversation.

Browse Source 
In lsa_BinaryString length and size are byte counts!

TODO: we may need to do byte order conversion in this functions too...

metze
This commit is contained in:
Stefan Metzmacher 2010-01-12 09:59:26 +01:00
parent ca9bc96b96
commit 232197e9ab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/dsdb/common/util.c
View File

@ -686,7 +686,7 @@ struct lsa_BinaryString samdb_result_parameters(TALLOC_CTX *mem_ctx,
if (!s.array) {
return s;
}
s.length = s.size = val->length/2;
s.length = s.size = val->length;
memcpy(s.array, val->data, val->length);
return s;
@ -935,7 +935,7 @@ int samdb_msg_add_parameters(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, s
const char *attr_name, struct lsa_BinaryString *parameters)
{
struct ldb_val val;
val.length = parameters->length * 2;
val.length = parameters->length;
val.data = (uint8_t *)parameters->array;
return ldb_msg_add_value(msg, attr_name, &val, NULL);
}