sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

libcli/security/dom_sid: remove a couple of lost comments

Browse Source 
The second one came with code obsoleting the "BIG NOTE" about 10 years
ago, but that code later wandered off somewhere else.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-03-16 15:39:05 +13:00 committed by Andrew Bartlett
parent fe8ce9e34e
commit 2398faef23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libcli/security/dom_sid.c
View File

@ -132,7 +132,6 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
{ {
const char *p; const char *p;
char *q; char *q;
/* BIG NOTE: this function only does SIDS where the identauth is not >= 2^32 */
uint64_t conv; uint64_t conv;
int error = 0; int error = 0;
@ -166,7 +165,6 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
goto format_error; goto format_error;
} }
/* When identauth >= UINT32_MAX, it's in hex with a leading 0x */
/* NOTE - the conv value is in big-endian format. */ /* NOTE - the conv value is in big-endian format. */
sidout->id_auth[0] = (conv & 0xff0000000000ULL) >> 40; sidout->id_auth[0] = (conv & 0xff0000000000ULL) >> 40;
sidout->id_auth[1] = (conv & 0x00ff00000000ULL) >> 32; sidout->id_auth[1] = (conv & 0x00ff00000000ULL) >> 32;