sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-01 04:58:35 +03:00
Code

python: Use secrets.token_bytes instead of random

Browse Source 
random should not be used to create secure random numbers for tokens.
The secrets module is exactly for this.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andreas Schneider 2024-04-03 10:54:41 +02:00 committed by Andrew Bartlett
parent decacb0e7e
commit 23e61d2ceb
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/samba/lsa_utils.py
View File

@ -22,8 +22,8 @@ from samba import NTSTATUSError, arcfour_encrypt, string_to_byte_array
from samba.ntstatus import (
NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE
)
import random
from samba import crypto
from secrets import token_bytes
def OpenPolicyFallback(
@ -76,9 +76,7 @@ def CreateTrustedDomainRelax(
):
def generate_AuthInfoInternal(session_key, incoming=None, outgoing=None):
confounder = [0] * 512
for i in range(len(confounder)):
confounder[i] = random.randint(0, 255)
confounder = string_to_byte_array(token_bytes(512))
trustpass = drsblobs.trustDomainPasswords()