From 24b0dad5b5014d80b8c62014808e3659d6cad29c Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Wed, 31 Jul 2024 13:27:40 +1200 Subject: [PATCH] dsdb:mod:operational: initialise a pointer (CID 1499411) A Coverity false positive (we check for error) but it is worth doing per README.Coding Signed-off-by: Douglas Bagnall Reviewed-by: Jennifer Sutton --- source4/dsdb/samdb/ldb_modules/operational.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source4/dsdb/samdb/ldb_modules/operational.c b/source4/dsdb/samdb/ldb_modules/operational.c index d9111184178..b86449b3b3b 100644 --- a/source4/dsdb/samdb/ldb_modules/operational.c +++ b/source4/dsdb/samdb/ldb_modules/operational.c @@ -557,7 +557,7 @@ static int construct_msds_isrodc_with_server_dn(struct ldb_module *module, struct ldb_dn *dn, struct ldb_request *parent) { - struct ldb_dn *server_dn; + struct ldb_dn *server_dn = NULL; const char *attr_obj_cat[] = { "objectCategory", NULL }; struct ldb_result *res; struct ldb_message_element *object_category; @@ -594,7 +594,7 @@ static int construct_msds_isrodc_with_computer_dn(struct ldb_module *module, struct ldb_request *parent) { int ret; - struct ldb_dn *server_dn; + struct ldb_dn *server_dn = NULL; ret = dsdb_module_reference_dn(module, msg, msg->dn, "serverReferenceBL", &server_dn, parent);