1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00

vfs_fruit: change default for "fruit:zero_file_id" option to yes

After discussion with folks at Apple it should be safe these days to rely on the
Mac to generate its own File-Ids and let Samba return 0 File-Ids.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2022-03-29 17:38:15 +02:00 committed by Jeremy Allison
parent 9fa67ba8ee
commit 24f4bea5b8
2 changed files with 5 additions and 5 deletions

View File

@ -397,12 +397,12 @@
identifier if the client has negotiated AAPL.</para>
<para>Mac applications and / or the Mac SMB client code expect the
on-disk file identifier to have the semantics of HFS+ Catalog Node
Identifier (CNID). Samba provides File-IDs based on a file's
initial creation date if the option <smbconfoption name="store dos
attributes"/> is enabled. Returning a file identifier of
Identifier (CNID). Samba provides File-IDs based on a file's inode
number which gets recycled across file creation and deletion and
can therefor not be used for Mac client. Returning a file identifier of
zero causes the Mac client to stop using and trusting the file id
returned from the server.</para>
<para>The default is <emphasis>no</emphasis>.</para>
<para>The default is <emphasis>yes</emphasis>.</para>
</listitem>
</varlistentry>

View File

@ -360,7 +360,7 @@ static int init_fruit_config(vfs_handle_struct *handle)
config->aapl_zero_file_id =
lp_parm_bool(SNUM(handle->conn), FRUIT_PARAM_TYPE_NAME,
"zero_file_id", false);
"zero_file_id", true);
config->readdir_attr_rsize = lp_parm_bool(
SNUM(handle->conn), "readdir_attr", "aapl_rsize", true);