sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-19 18:50:24 +03:00
Code

vfs_fruit: prepare fruit_pwrite_meta() for on-demand opening and writing

Browse Source 
This avoid creating files or blobs in our streams backend when a client
creates a stream but hasn't written anything yet. This is the only sane
way to implement the following semantics:

* client 1: create stream "file:foo"

* client 2: open stream "file:foo"

The second operation of client 2 must fail with NT_STATUS_NOT_FOUND.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4a5c9a9e73230f640eb045a3c47af75b5be9f1d6)
This commit is contained in:
Ralph Boehme 2018-08-22 15:21:08 +02:00 committed by Karolin Seeger
parent a3cc00f718
commit 257281c7c7
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
source3/modules/vfs_fruit.c
View File

@ -4485,10 +4485,44 @@ static ssize_t fruit_pwrite_meta_stream(vfs_handle_struct *handle,
files_struct *fsp, const void *data,
size_t n, off_t offset)
{
struct fio *fio = (struct fio *)VFS_FETCH_FSP_EXTENSION(handle, fsp);
AfpInfo *ai = NULL;
size_t nwritten;
int ret;
bool ok;
DBG_DEBUG("Path [%s] offset=%"PRIdMAX", size=%zd\n",
fsp_str_dbg(fsp), (intmax_t)offset, n);
if (fio == NULL) {
return -1;
}
if (fio->fake_fd) {
int fd;
ret = SMB_VFS_NEXT_CLOSE(handle, fsp);
if (ret != 0) {
DBG_ERR("Close [%s] failed: %s\n",
fsp_str_dbg(fsp), strerror(errno));
fsp->fh->fd = -1;
return -1;
}
fd = SMB_VFS_NEXT_OPEN(handle,
fsp->fsp_name,
fsp,
fio->flags,
fio->mode);
if (fd == -1) {
DBG_ERR("On-demand create [%s] in write failed: %s\n",
fsp_str_dbg(fsp), strerror(errno));
return -1;
}
fsp->fh->fd = fd;
fio->fake_fd = false;
}
ai = afpinfo_unpack(talloc_tos(), data);
if (ai == NULL) {
return -1;