sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

lib/replace: fix strlcat/strlcpy compile for Honggfuzz

Browse Source 
Otherwise we getthis kind of thing:

../../lib/replace/replace.c:837:3: error: implicit declaration of function 'strlcpy' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                strlcpy(buf, s, buflen);

../../third_party/heimdal/lib/roken/getarg.c:288:6: error: implicit declaration of function 'strlcat' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
            strlcat(buf, "]", sizeof(buf));

because we found the symbol names in libc, but didn't check that the
functions are declared in <string.h>. We already include
<bsd/string.h> whenever we have it.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug  8 05:35:08 UTC 2023 on atb-devel-224
This commit is contained in:
Douglas Bagnall 2023-07-28 15:36:21 +12:00 committed by Andrew Bartlett
parent f0e0ff262a
commit 269738d6ce
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/replace/wscript
View File

@ -448,6 +448,17 @@ def configure(conf):
if conf.CHECK_FUNCS_IN('strlcpy strlcat', 'bsd', headers='bsd/string.h',
checklibc=True):
strlcpy_in_bsd = True
elif conf.env.enable_fuzzing:
# Just to complicate it more, some versions of Honggfuzz have
# got strlcpy and strlcat in libc, but not in <string.h>
# (unless it is there coincidentally, on a BSD). Therefore we
# can't use CHECK_FUNCS alone to decide whether to add the
# headers to replace.h.
#
# As this is only known to happen on a fuzzing compiler, we'll
# skip the check when not in fuzzing mode.
conf.CHECK_HEADERS('bsd/string.h')
if not conf.CHECK_FUNCS('getpeereid'):
conf.CHECK_FUNCS_IN('getpeereid', 'bsd', headers='sys/types.h bsd/unistd.h')
if not conf.CHECK_FUNCS_IN('setproctitle', 'setproctitle', headers='setproctitle.h'):