sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

libcli: smb2: Never print length if smb2_signing_key_valid() fails for crypto blob.

Browse Source 
Blob could be NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14210

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov 16 09:47:38 UTC 2020 on sn-devel-184
This commit is contained in:
Jeremy Allison 2020-11-13 14:18:43 -08:00 committed by Volker Lendecke
parent a8ec830491
commit 26ba04a4d1
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libcli/smb/smb2_signing.c
View File

@ -92,8 +92,7 @@ NTSTATUS smb2_signing_sign_pdu(struct smb2_signing_key *signing_key,
} }
if (!smb2_signing_key_valid(signing_key)) { if (!smb2_signing_key_valid(signing_key)) {
DBG_WARNING("Wrong session key length %zu for SMB2 signing\n", DBG_WARNING("No signing key for SMB2 signing\n");
signing_key->blob.length);
return NT_STATUS_ACCESS_DENIED; return NT_STATUS_ACCESS_DENIED;
} }
@ -416,8 +415,7 @@ NTSTATUS smb2_signing_encrypt_pdu(struct smb2_signing_key *encryption_key,
tf = (uint8_t *)vector[0].iov_base; tf = (uint8_t *)vector[0].iov_base;
if (!smb2_signing_key_valid(encryption_key)) { if (!smb2_signing_key_valid(encryption_key)) {
DBG_WARNING("Wrong encryption key length %zu for SMB2 signing\n", DBG_WARNING("No encryption key for SMB2 signing\n");
encryption_key->blob.length);
return NT_STATUS_ACCESS_DENIED; return NT_STATUS_ACCESS_DENIED;
} }
@ -625,8 +623,7 @@ NTSTATUS smb2_signing_decrypt_pdu(struct smb2_signing_key *decryption_key,
tf = (uint8_t *)vector[0].iov_base; tf = (uint8_t *)vector[0].iov_base;
if (!smb2_signing_key_valid(decryption_key)) { if (!smb2_signing_key_valid(decryption_key)) {
DBG_WARNING("Wrong decryption key length %zu for SMB2 signing\n", DBG_WARNING("No decryption key for SMB2 signing\n");
decryption_key->blob.length);
return NT_STATUS_ACCESS_DENIED; return NT_STATUS_ACCESS_DENIED;
} }