sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-12 12:23:50 +03:00
Code Activity

r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?

Browse Source 
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
This commit is contained in:
Volker Lendecke
2006-10-06 14:39:47 +00:00
committed by Gerald (Jerry) Carter
parent 21516dc5ac
commit 26f2cb71eb
6 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/lib/ldb/common/ldb_modules.c
View File

@@ -81,7 +81,8 @@ const char **ldb_modules_list_from_string(struct ldb_context *ldb, TALLOC_CTX *m
int i;
/* spaces not admitted */
modstr = talloc_strdup_no_spaces(mem_ctx, string);
modstr = talloc_strdup_no_spaces((struct ldb_context *)mem_ctx,
string);
if ( ! modstr) {
return NULL;
}