sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-03 04:23:50 +03:00
Code Activity

Don't accidentally return success when sending a broken NET_SAMLOGON

Browse Source 
request.  This exposes a domain authentication bug with win2k where a rpc
fault is returned but not propagated up as an error.
This commit is contained in:
Tim Potter
-
parent b30232e2b7
commit 27cd7ac857
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
source/rpc_client/cli_netlogon.c
View File

@@ -378,6 +378,7 @@ static NTSTATUS cli_net_sam_logon_internal(struct cli_state *cli, NET_ID_INFO_CT
/* send the data on \PIPE\ */ /* send the data on \PIPE\ */
if (!rpc_api_pipe_req(cli, NET_SAMLOGON, &buf, &rbuf)) { if (!rpc_api_pipe_req(cli, NET_SAMLOGON, &buf, &rbuf)) {
DEBUG(0,("cli_net_sam_logon_internal: Error rpc_api_pipe_req failed.\n")); DEBUG(0,("cli_net_sam_logon_internal: Error rpc_api_pipe_req failed.\n"));
retval = NT_STATUS_UNSUCCESSFUL;
goto out; goto out;
} }