1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00

winbindd: call reset_cm_connection_on_error() from reconnect_need_retry()

This ensures we use the same disconnect logic in the reconnect backend,
which calls reconnect_need_retry(), and in the dual_srv frontend which
calls reset_cm_connection_on_error.

Both reset_cm_connection_on_error() and reconnect_need_retry() are very
similar, both return a bool indicating whether a retry should be
attempted, unfortunately the functions have a different default return,
so I don't dare unifying them, but instead just call one from the other.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Ralph Boehme 2018-03-12 12:20:04 +01:00
parent 17749a5d9f
commit 2837b796af

View File

@ -69,13 +69,7 @@ bool reconnect_need_retry(NTSTATUS status, struct winbindd_domain *domain)
return false; return false;
} }
if (NT_STATUS_EQUAL(status, NT_STATUS_IO_DEVICE_ERROR)) { reset_cm_connection_on_error(domain, status);
/*
* RPC call sent on expired session, needs
* reauthentication.
*/
invalidate_cm_connection(domain);
}
return true; return true;
} }