sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4/messaging/py: Fix callback return value leak

Browse Source 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-05-23 12:47:54 +12:00 committed by Andrew Bartlett
parent cfd80303f1
commit 28536f32da
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source4/lib/messaging/pymessaging.c
View File

@ -194,6 +194,7 @@ static void py_msg_callback_wrapper(struct imessaging_context *msg,
{
PyObject *py_server_id, *callback_and_tuple = (PyObject *)private_data;
PyObject *callback, *py_private;
PyObject *result = NULL;
struct server_id *p_server_id = NULL;
@ -218,11 +219,12 @@ static void py_msg_callback_wrapper(struct imessaging_context *msg,
py_server_id = py_return_ndr_struct("samba.dcerpc.server_id", "server_id", p_server_id, p_server_id);
talloc_unlink(NULL, p_server_id);
PyObject_CallFunction(callback, discard_const_p(char, "OiOs#"),
py_private,
msg_type,
py_server_id,
data->data, data->length);
result = PyObject_CallFunction(callback, discard_const_p(char, "OiOs#"),
py_private,
msg_type,
py_server_id,
data->data, data->length);
Py_XDECREF(result);
}
static PyObject *py_imessaging_register(PyObject *self, PyObject *args, PyObject *kwargs)