sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code

BUG 5429: Clarify log msgs re: failure to create BUILTIN\{Administrators,Users}

Browse Source 
Raise the debug msgs from Lvl 0 in the create_builtin_XX() functions
to prevent unnecessary panic from people reading the logs.
This commit is contained in:
Gerald W. Carter 2008-04-30 09:43:00 -05:00
parent 14327b11ba
commit 2983b9dc79
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/auth/token_util.c
View File

@ -210,7 +210,7 @@ static NTSTATUS create_builtin_users( void )
status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_USERS ); status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_USERS );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(0,("create_builtin_users: Failed to create Users\n")); DEBUG(5,("create_builtin_users: Failed to create Users\n"));
return status; return status;
} }
@ -221,7 +221,7 @@ static NTSTATUS create_builtin_users( void )
sid_append_rid(&dom_users, DOMAIN_GROUP_RID_USERS ); sid_append_rid(&dom_users, DOMAIN_GROUP_RID_USERS );
status = pdb_add_aliasmem( &global_sid_Builtin_Users, &dom_users); status = pdb_add_aliasmem( &global_sid_Builtin_Users, &dom_users);
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(0,("create_builtin_administrators: Failed to add Domain Users to" DEBUG(4,("create_builtin_administrators: Failed to add Domain Users to"
" Users\n")); " Users\n"));
return status; return status;
} }
@ -244,7 +244,7 @@ static NTSTATUS create_builtin_administrators( void )
status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_ADMINS ); status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_ADMINS );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(0,("create_builtin_administrators: Failed to create Administrators\n")); DEBUG(5,("create_builtin_administrators: Failed to create Administrators\n"));
return status; return status;
} }
@ -255,7 +255,7 @@ static NTSTATUS create_builtin_administrators( void )
sid_append_rid(&dom_admins, DOMAIN_GROUP_RID_ADMINS); sid_append_rid(&dom_admins, DOMAIN_GROUP_RID_ADMINS);
status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &dom_admins ); status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &dom_admins );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(0,("create_builtin_administrators: Failed to add Domain Admins" DEBUG(4,("create_builtin_administrators: Failed to add Domain Admins"
" Administrators\n")); " Administrators\n"));
return status; return status;
} }
@ -273,7 +273,7 @@ static NTSTATUS create_builtin_administrators( void )
if ( ret ) { if ( ret ) {
status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &root_sid ); status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &root_sid );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(0,("create_builtin_administrators: Failed to add root" DEBUG(4,("create_builtin_administrators: Failed to add root"
" Administrators\n")); " Administrators\n"));
return status; return status;
} }
@ -381,7 +381,8 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
become_root(); become_root();
status = create_builtin_administrators( ); status = create_builtin_administrators( );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(2,("create_local_nt_token: Failed to create BUILTIN\\Administrators group!\n")); DEBUG(2,("WARNING: Failed to create BUILTIN\\Administrators "
"group! Can Winbind allocate gids?\n"));
/* don't fail, just log the message */ /* don't fail, just log the message */
} }
unbecome_root(); unbecome_root();
@ -408,7 +409,8 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
become_root(); become_root();
status = create_builtin_users( ); status = create_builtin_users( );
if ( !NT_STATUS_IS_OK(status) ) { if ( !NT_STATUS_IS_OK(status) ) {
DEBUG(2,("create_local_nt_token: Failed to create BUILTIN\\Users group!\n")); DEBUG(2,("WARNING: Failed to create BUILTIN\\Users group! "
"Can Winbind allocate gids?\n"));
/* don't fail, just log the message */ /* don't fail, just log the message */
} }
unbecome_root(); unbecome_root();