sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00
Code

r19984: Must have been drunk yesterday.

Browse Source 
Freeing memctx is all we need, fix double free stupidity
This commit is contained in:
Simo Sorce 2006-12-01 16:13:06 +00:00 committed by Gerald (Jerry) Carter
parent d303cc7e62
commit 2a7454959e
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/smbd/sesssetup.c
View File

@ -302,8 +302,7 @@ static int reply_spnego_kerberos(connection_struct *conn,
DEBUG(1, ("PAM account restriction prevents user login\n"));
data_blob_free(&ap_rep);
data_blob_free(&session_key);
talloc_destroy(mem_ctx);
TALLOC_FREE(pw);
TALLOC_FREE(mem_ctx);
return ERROR_NT(nt_status_squash(ret));
}
}
@ -327,7 +326,7 @@ static int reply_spnego_kerberos(connection_struct *conn,
SAFE_FREE(client);
data_blob_free(&ap_rep);
data_blob_free(&session_key);
talloc_destroy(mem_ctx);
TALLOC_FREE(mem_ctx);
return ERROR_NT(nt_status_squash(NT_STATUS_LOGON_FAILURE));
}
}
@ -335,6 +334,8 @@ static int reply_spnego_kerberos(connection_struct *conn,
/* setup the string used by %U */
sub_set_smb_name( real_username );
C_FR
C_FREE
reload_services(True);
if ( map_domainuser_to_guest ) {
@ -352,7 +353,6 @@ static int reply_spnego_kerberos(connection_struct *conn,
data_blob_free(&ap_rep);
data_blob_free(&session_key);
TALLOC_FREE(mem_ctx);
TALLOC_FREE(pw);
return ERROR_NT(nt_status_squash(ret));
}
@ -366,7 +366,6 @@ static int reply_spnego_kerberos(connection_struct *conn,
data_blob_free(&ap_rep);
data_blob_free(&session_key);
TALLOC_FREE(mem_ctx);
TALLOC_FREE(pw);
return ERROR_NT(nt_status_squash(ret));
}
@ -390,7 +389,6 @@ static int reply_spnego_kerberos(connection_struct *conn,
SAFE_FREE(client);
data_blob_free(&ap_rep);
data_blob_free(&session_key);
TALLOC_FREE(pw);
TALLOC_FREE( mem_ctx );
TALLOC_FREE( server_info );
return ERROR_NT(nt_status_squash(ret));
@ -435,7 +433,6 @@ static int reply_spnego_kerberos(connection_struct *conn,
data_blob_free(&ap_rep_wrapped);
data_blob_free(&response);
TALLOC_FREE(mem_ctx);
TALLOC_FREE(pw);
return -1; /* already replied */
}