sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-22 02:50:28 +03:00
Code

s3: smbd: In filename_convert_dirfsp(), don't let an SMB1+POSIX client see a symlink to a directory with no permissions.

Browse Source 
This isn't 100% correct, but it gets us close enough
to the old behavior for SMB1+POSIX libsmbclient. If we went through a
symlink, and we got NT_STATUS_ACCESS_DENIED on the directory
containing the target, just don't allow the client to see the
intermediate path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Jeremy Allison 2022-08-01 17:55:23 -07:00
parent 5249cb3d0f
commit 2c4719a0cd
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source3/smbd/filename.c
View File

@ -3095,6 +3095,22 @@ next:
&substitute,
&unparsed);
#if defined(WITH_SMB1SERVER)
/*
* This isn't 100% correct, but it gets us close enough
* to the old behavior for SMB1+POSIX libsmbclient. If we went through a
* symlink, and we got NT_STATUS_ACCESS_DENIED on the directory
* containing the target, just don't allow the client to see the
* intermediate path.
*/
if (!conn->sconn->using_smb2 &&
(ucf_flags & UCF_POSIX_PATHNAMES) &&
symlink_redirects > 0 &&
NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
return NT_STATUS_OBJECT_PATH_NOT_FOUND;
}
#endif
if (!NT_STATUS_EQUAL(status, NT_STATUS_STOPPED_ON_SYMLINK)) {
return status;
}