From 2c76be76d5edad69c2daf5999266dddcbc2d1270 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Dieter=20Walln=C3=B6fer?= Date: Sun, 7 Nov 2010 20:09:51 +0100 Subject: [PATCH] s4:objectguid LDB module - objectGUIDs cannot be specified on add operations --- source4/dsdb/samdb/ldb_modules/objectguid.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/source4/dsdb/samdb/ldb_modules/objectguid.c b/source4/dsdb/samdb/ldb_modules/objectguid.c index 28d253a0d16..497ef1863b6 100644 --- a/source4/dsdb/samdb/ldb_modules/objectguid.c +++ b/source4/dsdb/samdb/ldb_modules/objectguid.c @@ -128,6 +128,7 @@ static int objectguid_add(struct ldb_module *module, struct ldb_request *req) struct ldb_context *ldb; struct ldb_request *down_req; struct ldb_message *msg; + struct ldb_message_element *el; struct GUID guid; uint64_t seq_num; int ret; @@ -143,8 +144,11 @@ static int objectguid_add(struct ldb_module *module, struct ldb_request *req) return ldb_next_request(module, req); } - if (ldb_msg_find_element(req->op.add.message, "objectGUID") != NULL) { - return ldb_next_request(module, req); + el = ldb_msg_find_element(req->op.add.message, "objectGUID"); + if (el != NULL) { + ldb_set_errstring(ldb, + "objectguid: objectGUID must not be specified!"); + return LDB_ERR_UNWILLING_TO_PERFORM; } ac = talloc(req, struct og_context);