sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code

r17181: Fix the build farm RAW-READ bug. When making a copy

Browse Source 
of the lock array in order to delete them individually
it's also important to make a copy of the *size* of
this array. Otherwise the unlock decrements the termination
index of your for loop :-). Doh ! Big thanks to Volker
for showing me how to set up the build farm to track
this one down. This is not a 3.0.23a issue.
Jeremy.
This commit is contained in:
Jeremy Allison 2006-07-21 22:02:54 +00:00 committed by Gerald (Jerry) Carter
parent ca0c73f281
commit 2c82a159ae
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/locking/brlock.c
View File

@ -1243,14 +1243,16 @@ void brl_close_fnum(struct byte_range_lock *br_lck)
if (unlock_individually) {
struct lock_struct *locks_copy;
unsigned int num_locks_copy;
/* Copy the current lock array. */
locks_copy = TALLOC_MEMDUP(br_lck, locks, br_lck->num_locks * sizeof(struct lock_struct));
if (!locks_copy) {
smb_panic("brl_close_fnum: talloc fail.\n");
}
num_locks_copy = br_lck->num_locks;
for (i=0; i < br_lck->num_locks; i++) {
for (i=0; i < num_locks_copy; i++) {
struct lock_struct *lock = &locks_copy[i];
if (lock->context.tid == tid && procid_equal(&lock->context.pid, &pid) &&