From 2e87c9d865828079f0023ff59b71db8ca455ad25 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 12 Sep 2023 19:03:10 +1200 Subject: [PATCH] s4-echo: Remove the "echo" server (port 7, RFC 862) in production builds This demonstration should never be enabled in production, if echo service is required other software is far better positioned to provide it. Reflection attacks on echo are a known issue. This is removed for consistency with the removal of rpcecho, but was never enabled in the default smb.conf so is mostly harmless. Signed-off-by: Andrew Bartlett --- source4/echo_server/wscript_build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/echo_server/wscript_build b/source4/echo_server/wscript_build index 8c40ec8c418..3d70f0c397a 100644 --- a/source4/echo_server/wscript_build +++ b/source4/echo_server/wscript_build @@ -6,5 +6,5 @@ bld.SAMBA_MODULE('ECHO', init_function='server_service_echo_init', deps='samba-hostconfig LIBTSOCKET LIBSAMBA_TSOCKET', local_include=False, - enabled=bld.AD_DC_BUILD_IS_ENABLED() + enabled=bld.CONFIG_GET('ENABLE_SELFTEST'), )