Doing a malloc(strlen(s)) then a pstrpcp(y, s) is just silly, make it a strdup

instead.

Andrew Bartlett
(This used to be commit c781e34d27)

source3/lib/util_str.c

@@ -669,13 +669,11 @@ static BOOL string_init(char **dest,const char *src)
 		}
 		*dest = null_string;
 	} else {
-		(*dest) = (char *)malloc(l+1);
+		(*dest) = strdup(src);
 		if ((*dest) == NULL) {
 			DEBUG(0,("Out of memory in string_init\n"));
 			return False;
 		}
-
-		pstrcpy(*dest,src);
 	}
 	return(True);
 }