sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

s3:utils: Tell users that workgroup/realm is required for ADS mode

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14695

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andreas Schneider 2021-04-28 12:09:21 +02:00 committed by Andrew Bartlett
parent 0d243b329b
commit 3286828609
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source3/utils/testparm.c
View File

@ -215,6 +215,8 @@ static int do_global_checks(void)
const struct loadparm_substitution *lp_sub = const struct loadparm_substitution *lp_sub =
loadparm_s3_global_substitution(); loadparm_s3_global_substitution();
fprintf(stderr, "\n");
if (lp_security() >= SEC_DOMAIN && !lp_encrypt_passwords()) { if (lp_security() >= SEC_DOMAIN && !lp_encrypt_passwords()) {
fprintf(stderr, "ERROR: in 'security=domain' mode the " fprintf(stderr, "ERROR: in 'security=domain' mode the "
"'encrypt passwords' parameter must always be " "'encrypt passwords' parameter must always be "
@ -222,6 +224,26 @@ static int do_global_checks(void)
ret = 1; ret = 1;
} }
if (lp_security() == SEC_ADS) {
const char *workgroup = lp_workgroup();
const char *realm = lp_realm();
if (workgroup == NULL || strlen(workgroup) == 0) {
fprintf(stderr,
"ERROR: The 'security=ADS' mode requires "
"'workgroup' parameter to be set!\n\n ");
ret = 1;
}
if (realm == NULL || strlen(realm) == 0) {
fprintf(stderr,
"ERROR: The 'security=ADS' mode requires "
"'realm' parameter to be set!\n\n ");
ret = 1;
}
}
if (lp_we_are_a_wins_server() && lp_wins_server_list()) { if (lp_we_are_a_wins_server() && lp_wins_server_list()) {
fprintf(stderr, "ERROR: both 'wins support = true' and " fprintf(stderr, "ERROR: both 'wins support = true' and "
"'wins server = <server list>' cannot be set in " "'wins server = <server list>' cannot be set in "