sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-14 00:58:38 +03:00
Code

s3: smbd: Strip any leading '\\' characters if the SMB2 DFS flag is set.

Browse Source 
MacOS clients send SMB2 DFS pathnames as \server\share\file\name.

Ensure smbd can cope with this by stipping any leading '\\'
characters from an SMB2 packet with the DFS flag set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15277

NB. The test for this is not back-ported to
4.17 as there are too many changes in the
test infrastructure and supporting client
libraries between 4.17 and master.

Back-ported from c9a6e242d15ee707a2e30f973fd37e80b3225aca.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(v4-17-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-17-test): Thu Jan  5 10:01:54 UTC 2023 on sn-devel-184
This commit is contained in:
Jeremy Allison 2023-01-03 18:28:54 -08:00 committed by Jule Anger
parent bc05daafbc
commit 33a5ca2f99
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source3/smbd/smb2_create.c
View File

@ -771,6 +771,17 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
in_file_attributes &= ~FILE_FLAG_POSIX_SEMANTICS;
is_dfs = (smb1req->flags2 & FLAGS2_DFS_PATHNAMES);
if (is_dfs) {
/*
* With a DFS flag set, remove any leading '\\'
* characters from in_name before further processing.
*/
while (in_name[0] == '\\') {
in_name++;
}
}
state->fname = talloc_strdup(state, in_name);
if (tevent_req_nomem(state->fname, req)) {
return tevent_req_post(req, state->ev);
@ -961,8 +972,6 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
state->lease_ptr = NULL;
}
is_dfs = (smb1req->flags2 & FLAGS2_DFS_PATHNAMES);
/* convert '\\' into '/' */
status = check_path_syntax_smb2(state->fname, is_dfs);
if (!NT_STATUS_IS_OK(status)) {