sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

s3: Slight reshaping of server_exists_parse

Browse Source 
Doing a copy and then do the compare is a bit pointless, use memcmp
This commit is contained in:
Volker Lendecke 2010-07-04 14:35:05 +02:00
parent f8e7077d5c
commit 34558ae945
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/lib/serverid.c
View File

@ -183,10 +183,12 @@ static int server_exists_parse(TDB_DATA key, TDB_DATA data, void *priv)
return -1;
}
/* memcpy, data.dptr might not be aligned */
memcpy(&unique_id, data.dptr, sizeof(unique_id));
state->exists = (state->id->unique_id == unique_id);
/*
* Use memcmp, not direct compare. data.dptr might not be
* aligned.
*/
state->exists =
(memcmp(&unique_id, data.dptr, sizeof(unique_id)) == 0);
return 0;
}