sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-27 07:42:04 +03:00
Code Activity

samba.tests.source: Verify that only executable python files (and only executable files) have a shebang line.

Browse Source
This commit is contained in:
Jelmer Vernooij
2012-03-15 16:03:36 +01:00
parent fa806eb7c6
commit 3530ac0149
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
source4/scripting/python/samba/tests/source.py
View File

@ -33,7 +33,6 @@ from samba.tests import (
)
def get_python_source_files():
"""Iterate over all Python source files."""
library_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "samba"))
@ -184,6 +183,26 @@ class TestSource(TestCase):
self.fail(self._format_message(illegal_newlines,
'Non-unix newlines were found in the following source files:'))
def test_shebang_lines(self):
"""Check that files with shebang lines and only those are executable."""
files_with_shebang = {}
files_without_shebang= {}
for fname, line_no, line in self._iter_source_files_lines():
if line_no >= 1:
continue
executable = (os.stat(fname).st_mode & 0111)
has_shebang = line.startswith("#!")
if has_shebang and not executable:
self._push_file(files_with_shebang, fname, line_no)
if not has_shebang and executable:
self._push_file(files_without_shebang, fname, line_no)
if files_with_shebang:
self.fail(self._format_message(files_with_shebang,
'Files with shebang line that are not executable:'))
if files_without_shebang:
self.fail(self._format_message(files_without_shebang,
'Files without shebang line that are executable:'))
pep8_ignore = [
'E401', # multiple imports on one line
'E501', # line too long