sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Code

r17381: - we don't need debug messages twice

Browse Source 
- also user_info->mapped is maybe uninitialized
  in auth_password_check() as it we do the mapping in
  auth_password_check_send()

that to Kai Blin <kai.blin@gmail.com> and valgrind to find
this bug

metze
(This used to be commit d88aabef64)
This commit is contained in:
Stefan Metzmacher 2006-08-03 09:29:12 +00:00 committed by Gerald (Jerry) Carter
parent 1057b4bea2
commit 358b1b2ea6
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source4/auth/auth.c
View File

@ -154,9 +154,6 @@ NTSTATUS auth_check_password(struct auth_context *auth_ctx,
struct auth_check_password_sync_state *sync_state;
NTSTATUS status;
DEBUG(3, ("auth_check_password: Checking password for unmapped user [%s]\\[%s]@[%s]\n",
user_info->client.domain_name, user_info->client.account_name, user_info->workstation_name));
sync_state = talloc_zero(auth_ctx, struct auth_check_password_sync_state);
NT_STATUS_HAVE_NO_MEMORY(sync_state);
@ -170,13 +167,6 @@ NTSTATUS auth_check_password(struct auth_context *auth_ctx,
if (NT_STATUS_IS_OK(status)) {
*server_info = talloc_steal(mem_ctx, sync_state->server_info);
DEBUG(5,("auth_check_password: authentication for user [%s\\%s] succeeded\n",
(*server_info)->domain_name, (*server_info)->account_name));
} else {
DEBUG(2,("auth_check_password: authentication for user [%s\\%s] FAILED with error %s\n",
user_info->mapped.domain_name, user_info->mapped.account_name,
nt_errstr(status)));
}
talloc_free(sync_state);
@ -339,12 +329,12 @@ NTSTATUS auth_check_password_recv(struct auth_check_password_request *req,
NT_STATUS_HAVE_NO_MEMORY(req);
if (NT_STATUS_IS_OK(req->status)) {
DEBUG(5,("auth_check_password: %s authentication for user [%s\\%s] succeeded\n",
DEBUG(5,("auth_check_password_recv: %s authentication for user [%s\\%s] succeeded\n",
req->method->ops->name, req->server_info->domain_name, req->server_info->account_name));
*server_info = talloc_steal(mem_ctx, req->server_info);
} else {
DEBUG(2,("auth_check_password: %s authentication for user [%s\\%s] FAILED with error %s\n",
DEBUG(2,("auth_check_password_recv: %s authentication for user [%s\\%s] FAILED with error %s\n",
(req->method ? req->method->ops->name : "NO_METHOD"),
req->user_info->mapped.domain_name,
req->user_info->mapped.account_name,