sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-20 22:50:26 +03:00
Code

smbd: Call file_free() just once in close_file()

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2022-02-01 17:21:24 +01:00 committed by Jeremy Allison
parent 244c5a7d31
commit 363ac75338
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source3/smbd/close.c
View File

@ -1532,12 +1532,10 @@ NTSTATUS close_file(struct smb_request *req, files_struct *fsp,
if (fsp->fake_file_handle != NULL) {
status = close_fake_file(req, fsp);
file_free(req, fsp);
} else if (fsp->print_file != NULL) {
/* FIXME: return spool errors */
print_spool_end(fsp, close_type);
fd_close(fsp);
file_free(req, fsp);
status = NT_STATUS_OK;
} else if (!fsp->fsp_flags.is_fsa) {
if (close_type == NORMAL_CLOSE) {
@ -1550,16 +1548,15 @@ NTSTATUS close_file(struct smb_request *req, files_struct *fsp,
}
SMB_ASSERT(close_type != NORMAL_CLOSE);
fd_close(fsp);
file_free(req, fsp);
status = NT_STATUS_OK;
} else if (fsp->fsp_flags.is_directory) {
status = close_directory(req, fsp, close_type);
file_free(req, fsp);
} else {
status = close_normal_file(req, fsp, close_type);
file_free(req, fsp);
}
file_free(req, fsp);
if (close_base_fsp) {
/*