sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00
Code

smbd: Introduce "ace" helper variable

Browse Source 
Use "psd->dacl->aces[0]" once instead of 3 times

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jennifer Sutton <jsutton@samba.org>
This commit is contained in:
Volker Lendecke 2024-08-05 13:42:09 +02:00
parent 99e4dc2ee1
commit 367bea1ca5
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source3/smbd/smb2_nttrans.c
View File

@ -177,6 +177,7 @@ static bool check_smb2_posix_chmod_ace(const struct files_struct *fsp,
struct security_descriptor *psd,
mode_t *pmode)
{
struct security_ace *ace = NULL;
int cmp;
/*
@ -203,18 +204,18 @@ static bool check_smb2_posix_chmod_ace(const struct files_struct *fsp,
if (psd->dacl->num_aces != 1) {
return false;
}
ace = &psd->dacl->aces[0];
if (psd->dacl->aces[0].trustee.num_auths != 3) {
if (ace->trustee.num_auths != 3) {
return false;
}
cmp = dom_sid_compare_domain(&global_sid_Unix_NFS_Mode,
&psd->dacl->aces[0].trustee);
cmp = dom_sid_compare_domain(&global_sid_Unix_NFS_Mode, &ace->trustee);
if (cmp != 0) {
return false;
}
*pmode = (mode_t)psd->dacl->aces[0].trustee.sub_auths[2];
*pmode = (mode_t)ace->trustee.sub_auths[2];
*pmode &= (S_IRWXU | S_IRWXG | S_IRWXO);
return true;