sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Code

libcli/auth: Ensure that the dns_names in/out parameter is preserved

Browse Source 
This is in dcerpc_netr_DsrUpdateReadOnlyServerDnsRecords, which has
status variables filled in by the server and placed in this in/out
array.

This showed up as a segfault in winbindd during RODC DNS update.

Andrew Bartlett

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Pair-programmed-with: Garming Sam <garming@catalyst.net.nz>
This commit is contained in:
Andrew Bartlett 2014-07-24 15:54:58 +12:00
parent 95d1828a24
commit 36ecbf34ba
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libcli/auth/netlogon_creds_cli.c
View File

@ -2754,7 +2754,14 @@ static void netlogon_creds_cli_DsrUpdateReadOnlyServerDnsRecords_done(struct tev
NTSTATUS result;
bool ok;
status = dcerpc_netr_DsrUpdateReadOnlyServerDnsRecords_recv(subreq, state,
/*
* We use state->dns_names as the memory context, as this is
* the only in/out variable and it has been overwritten by the
* out parameter from the server.
*
* We need to preserve the return value until the caller can use it.
*/
status = dcerpc_netr_DsrUpdateReadOnlyServerDnsRecords_recv(subreq, state->dns_names,
&result);
TALLOC_FREE(subreq);
if (tevent_req_nterror(req, status)) {