sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-06 17:32:29 +03:00
Code Activity

s3:locking:posix: remove uses of SMB_ASSERT() from get_windows_lock_ref_count()

Browse Source 
SMB_ASSERT is useless, since in non-developer build it does not actually
fail after the log message, but usual flow just continues.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Nov 25 14:59:53 CET 2011 on sn-devel-104
This commit is contained in:
Michael Adam
2011-11-10 23:11:54 +01:00
parent 95e686d59c
commit 37f7a2c82d
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source3/locking/posix.c
View File

@ -517,9 +517,20 @@ static int get_windows_lock_ref_count(files_struct *fsp)
goto done;
}
SMB_ASSERT(NT_STATUS_IS_OK(status));
if (!NT_STATUS_IS_OK(status)) {
DEBUG(0, ("get_windows_lock_ref_count: Error fetching "
"lock ref count for file %s: %s\n",
fsp_str_dbg(fsp), nt_errstr(status)));
goto done;
}
SMB_ASSERT(dbuf.dsize == sizeof(lock_ref_count));
if (dbuf.dsize != sizeof(lock_ref_count)) {
DEBUG(0, ("get_windows_lock_ref_count: invalid entry "
"in lock ref count record for file %s: "
"(invalid data size %u)\n",
fsp_str_dbg(fsp), (unsigned int)dbuf.dsize));
goto done;
}
memcpy(&lock_ref_count, dbuf.dptr, sizeof(lock_ref_count));
TALLOC_FREE(dbuf.dptr);