sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

s4-ldb: validate the type of the ldb argument to ldb_dn_new()

Browse Source 
It has been a common bug to get the first two arguments the wrong way
around
This commit is contained in:
Andrew Tridgell 2010-01-09 09:03:08 +11:00
parent 7eee8e053b
commit 39a4e2a38d
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source4/lib/ldb/common/ldb_dn.c
View File

@ -103,7 +103,13 @@ struct ldb_dn *ldb_dn_from_ldb_val(void *mem_ctx,
dn = talloc_zero(mem_ctx, struct ldb_dn);
LDB_DN_NULL_FAILED(dn);
dn->ldb = ldb;
dn->ldb = talloc_get_type(ldb, struct ldb_context);
if (dn->ldb == NULL) {
/* the caller probably got the arguments to
ldb_dn_new() mixed up */
talloc_free(dn);
return NULL;
}
if (strdn->data && strdn->length) {
const char *data = (const char *)strdn->data;