sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

brlock: don't leak lock_path onto talloc tos

Browse Source 
Also check for allocation failures.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2014-11-02 20:21:43 +01:00 committed by Jeremy Allison
parent d6792eca3c
commit 39f8ff2355
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source3/locking/brlock.c
View File

@ -342,6 +342,7 @@ static NTSTATUS brl_lock_failed(files_struct *fsp,
void brl_init(bool read_only)
{
int tdb_flags;
char *db_path;
if (brlock_db) {
return;
@ -358,15 +359,23 @@ void brl_init(bool read_only)
tdb_flags |= TDB_SEQNUM;
}
brlock_db = db_open(NULL, lock_path("brlock.tdb"),
db_path = lock_path("brlock.tdb");
if (db_path == NULL) {
DEBUG(0, ("out of memory!\n"));
return;
}
brlock_db = db_open(NULL, db_path,
SMB_OPEN_DATABASE_TDB_HASH_SIZE, tdb_flags,
read_only?O_RDONLY:(O_RDWR|O_CREAT), 0644,
DBWRAP_LOCK_ORDER_2, DBWRAP_FLAG_NONE);
if (!brlock_db) {
DEBUG(0,("Failed to open byte range locking database %s\n",
lock_path("brlock.tdb")));
db_path));
TALLOC_FREE(db_path);
return;
}
TALLOC_FREE(db_path);
}
/****************************************************************************