sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

dsdb: Fix CID 1453464: Error handling issues (CHECKED_RETURN)

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2019-09-03 10:35:33 +02:00 committed by Jeremy Allison
parent 09946c558f
commit 3a0047eaf1
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source4/dsdb/schema/schema_set.c
View File

@ -904,6 +904,7 @@ int dsdb_schema_fill_extended_dn(struct ldb_context *ldb, struct dsdb_schema *sc
const struct ldb_val *rdn; const struct ldb_val *rdn;
struct ldb_val guid; struct ldb_val guid;
NTSTATUS status; NTSTATUS status;
int ret;
struct ldb_dn *dn = ldb_dn_new(NULL, ldb, cur->defaultObjectCategory); struct ldb_dn *dn = ldb_dn_new(NULL, ldb, cur->defaultObjectCategory);
if (!dn) { if (!dn) {
@ -925,7 +926,12 @@ int dsdb_schema_fill_extended_dn(struct ldb_context *ldb, struct dsdb_schema *sc
talloc_free(dn); talloc_free(dn);
return ldb_operr(ldb); return ldb_operr(ldb);
} }
ldb_dn_set_extended_component(dn, "GUID", &guid); ret = ldb_dn_set_extended_component(dn, "GUID", &guid);
if (ret != LDB_SUCCESS) {
ret = ldb_error(ldb, ret, "Could not set GUID");
talloc_free(dn);
return ret;
}
cur->defaultObjectCategory = ldb_dn_get_extended_linearized(cur, dn, 1); cur->defaultObjectCategory = ldb_dn_get_extended_linearized(cur, dn, 1);
talloc_free(dn); talloc_free(dn);