mirror of
				https://github.com/samba-team/samba.git
				synced 2025-10-31 12:23:52 +03:00 
			
		
		
		
	r7633: this patch started as an attempt to make the dcerpc code use a given
event_context for the socket_connect() call, so that when things that
use dcerpc are running alongside anything else it doesn't block the
whole process during a connect.
Then of course I needed to change any code that created a dcerpc
connection (such as the auth code) to also take an event context, and
anything that called that and so on .... thus the size of the patch.
There were 3 places where I punted:
  - abartlet wanted me to add a gensec_set_event_context() call
    instead of adding it to the gensec init calls. Andrew, my
    apologies for not doing this. I didn't do it as adding a new
    parameter allowed me to catch all the callers with the
    compiler. Now that its done, we could go back and use
    gensec_set_event_context()
  - the ejs code calls auth initialisation, which means it should pass
    in the event context from the web server. I punted on that. Needs fixing.
  - I used a NULL event context in dcom_get_pipe(). This is equivalent
    to what we did already, but should be fixed to use a callers event
    context. Jelmer, can you think of a clean way to do that?
I also cleaned up a couple of things:
 - libnet_context_destroy() makes no sense. I removed it.
 - removed some unused vars in various places
			
			
This commit is contained in:
		
				
					committed by
					
						 Gerald (Jerry) Carter
						Gerald (Jerry) Carter
					
				
			
			
				
	
			
			
			
						parent
						
							d9a0c61801
						
					
				
				
					commit
					3a3025485b
				
			| @@ -22,6 +22,7 @@ | ||||
| #include "ldap_server/ldap_server.h" | ||||
| #include "auth/auth.h" | ||||
| #include "libcli/ldap/ldap.h" | ||||
| #include "smbd/service_stream.h" | ||||
|  | ||||
| static NTSTATUS ldapsrv_BindSimple(struct ldapsrv_call *call) | ||||
| { | ||||
| @@ -63,7 +64,8 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call) | ||||
| 	if (!call->conn->gensec) { | ||||
| 		call->conn->session_info = NULL; | ||||
|  | ||||
| 		status = gensec_server_start(call->conn, &call->conn->gensec); | ||||
| 		status = gensec_server_start(call->conn, &call->conn->gensec, | ||||
| 					     call->conn->connection->event.ctx); | ||||
| 		if (!NT_STATUS_IS_OK(status)) { | ||||
| 			DEBUG(1, ("Failed to start GENSEC server code: %s\n", nt_errstr(status))); | ||||
| 			return status; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user