s3-param Depricate 'password server = foo:12389' syntax

This was originally intended to allow the LDAP port on a DC to be
varied, but makes little sense to change one port when in an
environment where krb5, ldap, smb and potentially DCE/RPC over TCP are
involved.

Andrew Bartlett

source3/param/loadparm.c

@@ -9624,6 +9624,11 @@ static bool lp_load_ex(const char *pszFname,
 		DEBUG(1, ("WARNING: The security=server option is deprecated\n"));
 	}
 
+	if (lp_security() == SEC_ADS && strchr(lp_passwordserver(), ':')) {
+		DEBUG(1, ("WARNING: The optional ':port' in password server = %s is deprecated\n",
+			  lp_passwordserver()));
+	}
+
 	bLoaded = True;
 
 	/* Now we check bWINSsupport and set szWINSserver to 127.0.0.1 */