sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

fuzzing: fuzz_sddl_parse forgives bad utf-8

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-09-22 15:19:32 +12:00 committed by Andrew Bartlett
parent e4da279b1c
commit 3be69fc3dc
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/fuzzing/fuzz_sddl_parse.c
View File

@ -20,6 +20,7 @@
#include "libcli/security/security.h"
#include "librpc/gen_ndr/conditional_ace.h"
#include "fuzzing/fuzzing.h"
#include "util/charset/charset.h"
#define MAX_LENGTH (100 * 1024 - 1)
static char sddl_string[MAX_LENGTH + 1] = {0};
@ -55,6 +56,28 @@ int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len)
goto end;
}
result = sddl_encode(mem_ctx, sd1, &dom_sid);
if (result == NULL) {
/*
* Because Samba currently doesn't enforce strict
* utf-8 parsing, illegal utf-8 sequences in
* sddl_string could have ferried bad characters
* through into the security descriptor conditions
* that we then find we can't encode.
*
* The proper solution is strict UTF-8 enforcement in
* sddl_decode, but for now we forgive unencodable
* security descriptors made from bad utf-8.
*/
size_t byte_len, char_len, utf16_len;
ok = utf8_check(sddl_string, len,
&byte_len, &char_len, &utf16_len);
if (!ok) {
goto end;
}
/* utf-8 was fine, but we couldn't encode! */
abort();
}
sd2 = sddl_decode(mem_ctx, result, &dom_sid);
if (sd2 == NULL) {
if (strlen(result) > CONDITIONAL_ACE_MAX_LENGTH) {