sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code

smbd: Simplify reopen_from_fsp()

Browse Source 
Pass down a dummy "file_created" variable in open_directory(), remove
a unneeded if-condition.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2023-10-15 14:31:03 +02:00 committed by Jeremy Allison
parent 9f63fad392
commit 3c20ea9df2
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source3/smbd/open.c
View File

@ -1272,13 +1272,8 @@ static NTSTATUS reopen_from_fsp(struct files_struct *dirfsp,
const struct vfs_open_how *how,
bool *p_file_created)
{
bool __unused_file_created = false;
NTSTATUS status;
if (p_file_created == NULL) {
p_file_created = &__unused_file_created;
}
/*
* TODO: should we move this to the VFS layer?
* SMB_VFS_REOPEN_FSP()?
@ -4918,12 +4913,13 @@ static NTSTATUS open_directory(connection_struct *conn,
struct vfs_open_how how = {
.flags = O_RDONLY | O_DIRECTORY,
};
bool file_created;
status = reopen_from_fsp(fsp->conn->cwd_fsp,
fsp->fsp_name,
fsp,
&how,
NULL);
&file_created);
if (!NT_STATUS_IS_OK(status)) {
DBG_INFO("Could not open fd for [%s]: %s\n",
smb_fname_str_dbg(smb_dname),