sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-17 04:23:50 +03:00
Code Activity

tests: Remove redundant credentials from auth_log tests

Browse Source 
The LDB connection in these tests is to the direct sam.ldb file on disk,
so the credentials are not actually needed (and in fact, weren't event
initialized correctly). These tests always need to run on the DC itself
(i.e. :local testenv) because they use ncalrpc connections.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Tim Beale
2019-01-28 14:11:09 +13:00
committed by Andrew Bartlett
parent 4a9f7d2456
commit 3ce28f918c
3 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/samba/tests/auth_log_netlogon.py
View File

@@ -47,12 +47,9 @@ class AuthLogTestsNetLogon(samba.tests.auth_log_base.AuthLogTestBase):
def setUp(self): def setUp(self):
super(AuthLogTestsNetLogon, self).setUp() super(AuthLogTestsNetLogon, self).setUp()
self.lp = samba.tests.env_loadparm() self.lp = samba.tests.env_loadparm()
self.creds = Credentials()
self.session = system_session() self.session = system_session()
self.ldb = SamDB( self.ldb = SamDB(
session_info=self.session, session_info=self.session,
credentials=self.creds,
lp=self.lp) lp=self.lp)
self.domain = os.environ["DOMAIN"] self.domain = os.environ["DOMAIN"]

3
python/samba/tests/auth_log_netlogon_bad_creds.py
View File

@@ -49,12 +49,9 @@ class AuthLogTestsNetLogonBadCreds(samba.tests.auth_log_base.AuthLogTestBase):
def setUp(self): def setUp(self):
super(AuthLogTestsNetLogonBadCreds, self).setUp() super(AuthLogTestsNetLogonBadCreds, self).setUp()
self.lp = samba.tests.env_loadparm() self.lp = samba.tests.env_loadparm()
self.creds = Credentials()
self.session = system_session() self.session = system_session()
self.ldb = SamDB( self.ldb = SamDB(
session_info=self.session, session_info=self.session,
credentials=self.creds,
lp=self.lp) lp=self.lp)
self.domain = os.environ["DOMAIN"] self.domain = os.environ["DOMAIN"]

3
python/samba/tests/auth_log_samlogon.py
View File

@@ -47,12 +47,9 @@ class AuthLogTestsSamLogon(samba.tests.auth_log_base.AuthLogTestBase):
def setUp(self): def setUp(self):
super(AuthLogTestsSamLogon, self).setUp() super(AuthLogTestsSamLogon, self).setUp()
self.lp = samba.tests.env_loadparm() self.lp = samba.tests.env_loadparm()
self.creds = Credentials()
self.session = system_session() self.session = system_session()
self.ldb = SamDB( self.ldb = SamDB(
session_info=self.session, session_info=self.session,
credentials=self.creds,
lp=self.lp) lp=self.lp)
self.domain = os.environ["DOMAIN"] self.domain = os.environ["DOMAIN"]