From 3d935fdcb9c3677dced4fa22d5c8d1a0d48ef6c2 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Wed, 29 Jun 2022 16:02:05 +1200 Subject: [PATCH] ldb: Remove old misleading comments Commit bed9efa6cda17ecca91bdf71227ec656b94dcf94 introduced ldb_msg_add_linearized_dn() to replace ldb_msg_add_dn(), but retained the now-incorrect associated comment. The comment later made its way into a function added later by commit 'CVE-2022-32746 ldb: Add functions for appending to an ldb_message'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15008 Signed-off-by: Joseph Sutton Reviewed-by: Andreas Schneider --- lib/ldb/common/ldb_msg.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/ldb/common/ldb_msg.c b/lib/ldb/common/ldb_msg.c index a308b32ed42..3242447b544 100644 --- a/lib/ldb/common/ldb_msg.c +++ b/lib/ldb/common/ldb_msg.c @@ -569,8 +569,6 @@ int ldb_msg_add_steal_string(struct ldb_message *msg, /* add a DN element to a message - WARNING: this uses the linearized string from the dn, and does not - copy the string. */ int ldb_msg_add_linearized_dn(struct ldb_message *msg, const char *attr_name, struct ldb_dn *dn) @@ -703,8 +701,6 @@ int ldb_msg_append_string(struct ldb_message *msg, /* append a DN element to a message - WARNING: this uses the linearized string from the dn, and does not - copy the string. */ int ldb_msg_append_linearized_dn(struct ldb_message *msg, const char *attr_name, struct ldb_dn *dn, int flags)