mirror of
https://github.com/samba-team/samba.git
synced 2025-02-28 01:58:17 +03:00
selftest: Add basic smbcacls test(s)
Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Noel Power
Jeremy Allison
parent
61e93698e5
commit
3dced6a436
147
python/samba/tests/blackbox/smbcacls.py
Normal file
147
python/samba/tests/blackbox/smbcacls.py
Normal file
@ -0,0 +1,147 @@
|
||||
# Blackbox tests for smbcaclcs
|
||||
#
|
||||
# Copyright (C) Noel Power noel.power@suse.com
|
||||
#
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
#
|
||||
from __future__ import print_function
|
||||
from samba.tests import BlackboxTestCase, BlackboxProcessError
|
||||
from samba.samba3 import param as s3param
|
||||
|
||||
from samba.credentials import Credentials
|
||||
|
||||
import os
|
||||
|
||||
class SmbCaclsBlockboxTestBase(BlackboxTestCase):
|
||||
|
||||
def setUp(self):
|
||||
super(SmbCaclsBlockboxTestBase, self).setUp()
|
||||
self.lp = s3param.get_context()
|
||||
self.server = os.environ["SERVER"]
|
||||
self.user = os.environ["USER"]
|
||||
self.passwd = os.environ["PASSWORD"]
|
||||
self.creds = Credentials()
|
||||
self.creds.guess(self.lp)
|
||||
self.creds.set_username(self.user)
|
||||
self.creds.set_password(self.passwd)
|
||||
self.testdir = os.getenv("TESTDIR", "smbcacls")
|
||||
self.share = os.getenv("SHARE", "tmp")
|
||||
|
||||
def tearDown(self):
|
||||
try:
|
||||
# remote removal doesn't seem to work with dfs share(s)
|
||||
# #TODO find out if this is intentional (it very well might be)
|
||||
# so if we fail with remote remove perform local remove
|
||||
# (of remote files) instead
|
||||
smbclient_args = self.build_test_cmd("smbclient", ["//%s/%s" % (self.server, self.share), "-c", "deltree %s/*" % self.testdir])
|
||||
self.check_output(smbclient_args)
|
||||
except Exception as e:
|
||||
print("remote remove failed: %s" % str(e))
|
||||
dirpath = os.path.join(os.environ["LOCAL_PATH"],self.testdir)
|
||||
print("falling back to removing contents of local dir: %s" % dirpath)
|
||||
if os.path.exists(dirpath):
|
||||
for entry in os.listdir(dirpath):
|
||||
fullpath = os.path.join(dirpath, entry)
|
||||
if os.path.isdir(fullpath):
|
||||
import shutil
|
||||
shutil.rmtree(fullpath)
|
||||
else:
|
||||
os.unlink(fullpath)
|
||||
|
||||
def ace_dump(self, ace):
|
||||
for key, value in ace.items():
|
||||
print ("%s=%s," % (key, value), end="")
|
||||
print ("")
|
||||
|
||||
def ace_cmp(self, left, right):
|
||||
for key, value in left.items():
|
||||
if key == "user_dom":
|
||||
continue
|
||||
if not key in right:
|
||||
print ("no entry for: %s" % key)
|
||||
return False
|
||||
if value != right[key]:
|
||||
print ("mismatch: %s:%s != %s:%s" % (key, value, key, right[key]))
|
||||
return False
|
||||
return True
|
||||
|
||||
def ace_parse_str(self, ace):
|
||||
parts = ace.split(':')
|
||||
result = {}
|
||||
if parts[0] != "ACL":
|
||||
raise Exception("invalid ace string:%" % ace)
|
||||
if "\\" in parts[1]:
|
||||
result["user_dom"], result["user"] = parts[1].split("\\")
|
||||
elif "/" in parts[1]:
|
||||
result["user_dom"], result["user"] = parts[1].split("/")
|
||||
else:
|
||||
result["user"] = parts[1]
|
||||
result["type"], result["inherit"], result["permissions"] = parts[2].split('/')
|
||||
return result
|
||||
|
||||
def build_test_cmd(self, cmd, args):
|
||||
cmd = [cmd, "-U%s%%%s" % (self.user, self.passwd)]
|
||||
cmd.extend(args)
|
||||
return cmd
|
||||
|
||||
def smb_cacls(self, args):
|
||||
cacls_args = ["//%s/%s" % (self.server, self.share)]
|
||||
cacls_args.extend(args)
|
||||
out = self.check_output(self.build_test_cmd("smbcacls", cacls_args))
|
||||
return out
|
||||
|
||||
def create_remote_test_file(self, remotepath):
|
||||
with self.mktemp() as tmpfile:
|
||||
filepath = os.path.join(self.testdir, remotepath)
|
||||
(dirpath, filename) = os.path.split(remotepath)
|
||||
remote_path = ""
|
||||
if len(dirpath):
|
||||
remote_path = self.testdir.replace("/", "\\", 10)
|
||||
for seg in dirpath.split(os.sep):
|
||||
remote_path = remote_path + "\\" + seg
|
||||
smbclient_args = self.build_test_cmd("smbclient", ["//%s/%s" % (self.server, self.share), "-c", "mkdir %s" % remote_path])
|
||||
self.check_output(smbclient_args)
|
||||
smbclient_args = self.build_test_cmd("smbclient", ["//%s/%s" % (self.server, self.share), "-c", "put %s %s" % (tmpfile, filepath)])
|
||||
out = self.check_output(smbclient_args)
|
||||
return filepath
|
||||
|
||||
|
||||
def file_ace_check(self, remotepath, ace):
|
||||
smbcacls_args = self.build_test_cmd("smbcacls",
|
||||
["//%s/%s" % (self.server, self.share), "--get",
|
||||
remotepath])
|
||||
try:
|
||||
output = self.check_output(smbcacls_args)
|
||||
except BlackboxProcessError as e:
|
||||
print(str(e))
|
||||
return False
|
||||
out_str = output.decode()
|
||||
aces = []
|
||||
for line in out_str.split("\n"):
|
||||
if line.startswith("ACL"):
|
||||
aces.append(line)
|
||||
for acl in aces:
|
||||
acl_ace = self.ace_parse_str(acl)
|
||||
if ace["user"] == acl_ace["user"] and ace["type"] == acl_ace["type"]:
|
||||
print ("found ACE for %s" % acl_ace["user"])
|
||||
if not self.ace_cmp(acl_ace, ace):
|
||||
print ("differences between file ACE: ")
|
||||
self.ace_dump(acl_ace)
|
||||
print ("and expected ACE: ")
|
||||
self.ace_dump(ace)
|
||||
else:
|
||||
print ("matched ACE for %s" % acl_ace["user"])
|
||||
self.ace_dump(ace)
|
||||
return True
|
||||
return False
|
||||
133
python/samba/tests/blackbox/smbcacls_basic.py
Normal file
133
python/samba/tests/blackbox/smbcacls_basic.py
Normal file
@ -0,0 +1,133 @@
|
||||
# Blackbox tests for smbcaclcs
|
||||
#
|
||||
# Copyright (C) Noel Power noel.power@suse.com
|
||||
#
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
#
|
||||
from __future__ import print_function
|
||||
from samba.tests.blackbox.smbcacls import SmbCaclsBlockboxTestBase
|
||||
from samba.tests import BlackboxProcessError
|
||||
|
||||
class BasicSmbCaclsTests(SmbCaclsBlockboxTestBase):
|
||||
|
||||
def setUp(self):
|
||||
super(BasicSmbCaclsTests, self).setUp()
|
||||
|
||||
def test_simple_single_set(self):
|
||||
"""test smbcacls '--set' attempts to overwrite the ACL for the file
|
||||
|
||||
before:
|
||||
|
||||
+-test_dir/
|
||||
+-file.1 (I)(F)
|
||||
|
||||
after/expected:
|
||||
|
||||
+-test_dir/
|
||||
+-file.1 (F)"""
|
||||
|
||||
file1 = "file-1"
|
||||
try:
|
||||
filepath = self.create_remote_test_file(file1)
|
||||
except BlackboxProcessError as e:
|
||||
self.fail(str(e))
|
||||
|
||||
acl = ("ACL:%s:ALLOWED/0x0/FULL" % self.user)
|
||||
command = "bin/smbcacls -U%s%%%s --set %s //%s/%s %s" % (self.user, self.passwd, acl, self.server, self.share, filepath)
|
||||
|
||||
try:
|
||||
result = self.check_output(command)
|
||||
except BlackboxProcessError as e:
|
||||
self.fail(str(e))
|
||||
|
||||
ace = self.ace_parse_str(acl)
|
||||
self.assertTrue(self.file_ace_check(filepath, ace))
|
||||
|
||||
def test_simple_single_mod(self):
|
||||
|
||||
"""test smbcacls '--modify' attempts to modify the ACL for the file
|
||||
(note: first part of the test 'set' ACL to (F) then attempts to modify
|
||||
before:
|
||||
|
||||
+-test_dir/
|
||||
+-file.1 (F)
|
||||
|
||||
after/expected:
|
||||
|
||||
+-test_dir/
|
||||
+-file.1 (READ)"""
|
||||
|
||||
acl_str = "ACL:%s:ALLOWED/0x0/FULL" % self.user
|
||||
try:
|
||||
remotepath = self.create_remote_test_file("file-1")
|
||||
|
||||
self.smb_cacls(["--set", acl_str, remotepath])
|
||||
|
||||
ace = self.ace_parse_str(acl_str)
|
||||
self.assertTrue(self.file_ace_check(remotepath, ace))
|
||||
|
||||
# overwrite existing entry
|
||||
acl_str = "ACL:%s:ALLOWED/0x0/READ" % self.user
|
||||
self.smb_cacls(["--modify", acl_str, remotepath])
|
||||
|
||||
ace = self.ace_parse_str(acl_str)
|
||||
self.assertTrue(self.file_ace_check(remotepath, ace))
|
||||
except BlackboxProcessError as e:
|
||||
self.fail(str(e))
|
||||
|
||||
def test_simple_single_del(self):
|
||||
"""test smbcacls '--delete' attempts to delete the ACL for the file
|
||||
(note: first part of the test 'set' ACL to (F) then attempts to delete
|
||||
before:
|
||||
|
||||
+-tar_test_dir/
|
||||
+-file.1 (F)
|
||||
|
||||
after/expected:
|
||||
|
||||
+-tar_test_dir/
|
||||
+-file.1 (none) - meaning no (F) ACL for this user"""
|
||||
|
||||
acl_str = "ACL:%s:ALLOWED/0x0/FULL" % self.user
|
||||
|
||||
try:
|
||||
remotepath = self.create_remote_test_file("file-1")
|
||||
|
||||
# only a single ACE string in the ACL
|
||||
ace = self.ace_parse_str(acl_str)
|
||||
self.assertTrue(self.file_ace_check(remotepath, ace))
|
||||
|
||||
self.smb_cacls(["--delete", acl_str, remotepath])
|
||||
self.assertFalse(self.file_ace_check(remotepath, ace))
|
||||
except BlackboxProcessError as e:
|
||||
self.fail(str(e))
|
||||
|
||||
|
||||
def test_simple_single_add(self):
|
||||
acl_str = "ACL:%s:ALLOWED/0x0/FULL" % self.user
|
||||
dny_str = "ACL:%s:DENIED/0x0/READ" % self.user
|
||||
|
||||
try:
|
||||
remotepath = self.create_remote_test_file("file-1")
|
||||
|
||||
self.smb_cacls(["--set", acl_str, remotepath])
|
||||
|
||||
ace = self.ace_parse_str(acl_str)
|
||||
self.assertTrue(self.file_ace_check(remotepath, ace))
|
||||
|
||||
self.smb_cacls(["--set", dny_str, remotepath])
|
||||
ace = self.ace_parse_str(dny_str)
|
||||
self.assertTrue(self.file_ace_check(remotepath, ace))
|
||||
except BlackboxProcessError as e:
|
||||
self.fail(str(e))
|
||||
@ -1329,6 +1329,9 @@ sub setup_fileserver
|
||||
my $tarmode_sharedir="$share_dir/tarmode";
|
||||
push(@dirs,$tarmode_sharedir);
|
||||
|
||||
my $smbcacls_sharedir="$share_dir/smbcacls";
|
||||
push(@dirs,$smbcacls_sharedir);
|
||||
|
||||
my $usershare_sharedir="$share_dir/usershares";
|
||||
push(@dirs,$usershare_sharedir);
|
||||
|
||||
|
||||
@ -925,6 +925,8 @@ planoldpythontestsuite("none", "samba.tests.loadparm")
|
||||
planoldpythontestsuite("fileserver",
|
||||
"samba.tests.blackbox.mdfind",
|
||||
extra_args=['-U"$USERNAME%$PASSWORD"'])
|
||||
planoldpythontestsuite("fileserver",
|
||||
"samba.tests.blackbox.smbcacls_basic")
|
||||
|
||||
#
|
||||
# Want a selection of environments across the process models
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user