sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

smbd: remove oplock paranoia check from file_find_dif()

Browse Source 
Since 4.16 stat opens will have a real fd, the only case where currently the fd
can still be -1 is a POSIX request on a symlink.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2022-12-01 21:38:32 +01:00 committed by Jeremy Allison
parent 6e1f58ab7c
commit 3ece2cb807
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source3/smbd/files.c
View File

@ -1564,22 +1564,6 @@ files_struct *file_find_dif(struct smbd_server_connection *sconn,
if (count > 10) {
DLIST_PROMOTE(sconn->files, fsp);
}
/* Paranoia check. */
if ((fsp_get_pathref_fd(fsp) == -1) &&
(fsp->oplock_type != NO_OPLOCK &&
fsp->oplock_type != LEASE_OPLOCK))
{
struct file_id_buf idbuf;
DBG_ERR("file %s file_id = "
"%s, gen = %u oplock_type = %u is a "
"stat open with oplock type !\n",
fsp_str_dbg(fsp),
file_id_str_buf(fsp->file_id, &idbuf),
(unsigned int)fh_get_gen_id(fsp->fh),
(unsigned int)fsp->oplock_type);
smb_panic("file_find_dif");
}
return fsp;
}