sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

smbd: leave comment on broken SMB1 POSIX open handling of SMB_O_DIRECT

Browse Source 
Since e0814dc508 the passed in attributes get
replaced by the mode in create_file_default().

As FILE_FLAG_NO_BUFFERING is never checked when doing the final IO, it doesn't
really matter.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2023-11-24 16:29:57 +01:00 committed by Jeremy Allison
parent 0b74adb3f0
commit 3f73bb591c
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source3/smbd/smb1_trans2.c
View File

@ -3461,6 +3461,12 @@ static NTSTATUS smb_posix_open(connection_struct *conn,
access_mask |= FILE_APPEND_DATA;
}
if (wire_open_mode & SMB_O_DIRECT) {
/*
* BUG: this doesn't work anymore since
* e0814dc5082dd4ecca8a155e0ce24b073158fd92. But since
* FILE_FLAG_NO_BUFFERING isn't used at all in the IO codepath,
* it doesn't really matter.
*/
attributes |= FILE_FLAG_NO_BUFFERING;
}