From 3f77bf2ce318b51547c36f315b34a062ba7afccf Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Tue, 5 Nov 2013 06:31:29 +1100 Subject: [PATCH] testparm: Warnings should not cause failure Remove the return code of 1 associated with some warnings. Warnings should not cause failure. If any of these cases should cause a failure then they should be changed to errors. Signed-off-by: Martin Schwenke Reviewed-by: Christof Schmitt Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Wed Nov 20 12:19:59 CET 2013 on sn-devel-104 --- source3/utils/testparm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c index 1c13b52565c..ce853539932 100644 --- a/source3/utils/testparm.c +++ b/source3/utils/testparm.c @@ -86,7 +86,6 @@ static int do_global_checks(void) if (strequal(lp_workgroup(), lp_netbios_name())) { fprintf(stderr, "WARNING: 'workgroup' and 'netbios name' " "must differ.\n\n"); - ret = 1; } if (!directory_exist_stat(lp_lockdir(), &st)) { @@ -97,7 +96,6 @@ static int do_global_checks(void) fprintf(stderr, "WARNING: lock directory %s should have " "permissions 0755 for browsing to work\n\n", lp_lockdir()); - ret = 1; } if (!directory_exist_stat(lp_statedir(), &st)) { @@ -108,7 +106,6 @@ static int do_global_checks(void) fprintf(stderr, "WARNING: state directory %s should have " "permissions 0755 for browsing to work\n\n", lp_statedir()); - ret = 1; } if (!directory_exist_stat(lp_cachedir(), &st)) { @@ -119,7 +116,6 @@ static int do_global_checks(void) fprintf(stderr, "WARNING: cache directory %s should have " "permissions 0755 for browsing to work\n\n", lp_cachedir()); - ret = 1; } if (!directory_exist_stat(lp_piddir(), &st)) {