sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

ctdb-locking: Back-off from logging every 10 seconds

Browse Source 
If ctdb_lock_helper cannot get a lock within 10 seconds, ctdb daemon
logs a message and invokes an external debug script.  This is repeated
every 10 seconds.

In case of a contention or on a loaded system, there can be multiple
ctdb_lock_helper processes waiting to get lock on record(s).  For each
lock request taking longer, ctdb daemon will flood the log every
10 seconds.  Instead of logging aggressively every 10 seconds, relax
logging to every 100s and 1000s if the elapsed time has exceeded 100s
and 1000s respectively.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar  5 12:06:44 CET 2015 on sn-devel-104
This commit is contained in:
Amitay Isaacs 2015-03-04 15:36:05 +11:00 committed by Michael Adam
parent 956d1dbfd9
commit 3f97be6d0f
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ctdb/server/ctdb_lock.c
View File

@ -486,6 +486,8 @@ static void ctdb_lock_timeout_handler(struct tevent_context *ev,
struct lock_context *lock_ctx;
struct ctdb_context *ctdb;
pid_t pid;
double elapsed_time;
int new_timer;
lock_ctx = talloc_get_type_abort(private_data, struct lock_context);
ctdb = lock_ctx->ctdb;
@ -495,16 +497,17 @@ static void ctdb_lock_timeout_handler(struct tevent_context *ev,
lock_ctx->ttimer = NULL;
return;
}
elapsed_time = timeval_elapsed(&lock_ctx->start_time);
if (lock_ctx->ctdb_db) {
DEBUG(DEBUG_WARNING,
("Unable to get %s lock on database %s for %.0lf seconds\n",
(lock_ctx->type == LOCK_RECORD ? "RECORD" : "DB"),
lock_ctx->ctdb_db->db_name,
timeval_elapsed(&lock_ctx->start_time)));
lock_ctx->ctdb_db->db_name, elapsed_time));
} else {
DEBUG(DEBUG_WARNING,
("Unable to get ALLDB locks for %.0lf seconds\n",
timeval_elapsed(&lock_ctx->start_time)));
elapsed_time));
}
/* Fire a child process to find the blocking process. */
@ -529,11 +532,20 @@ static void ctdb_lock_timeout_handler(struct tevent_context *ev,
" Unable to setup lock debugging - no memory?\n"));
}
/* Back-off logging if lock is not obtained for a long time */
if (elapsed_time < 100.0) {
new_timer = 10;
} else if (elapsed_time < 1000.0) {
new_timer = 100;
} else {
new_timer = 1000;
}
/* reset the timeout timer */
// talloc_free(lock_ctx->ttimer);
lock_ctx->ttimer = tevent_add_timer(ctdb->ev,
lock_ctx,
timeval_current_ofs(10, 0),
timeval_current_ofs(new_timer, 0),
ctdb_lock_timeout_handler,
(void *)lock_ctx);
}