sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

auth: Slightly simplify smb_pwd_check_ntlmv1()

Browse Source 
Do an early return for the failure case

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Volker Lendecke 2020-01-03 14:10:00 +01:00 committed by Gary Lockyer
parent 2bd941cc12
commit 4014d91b9a
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libcli/auth/ntlm_check.c
View File

@ -37,6 +37,7 @@ static bool smb_pwd_check_ntlmv1(TALLOC_CTX *mem_ctx,
/* Finish the encryption of part_passwd. */
uint8_t p24[24];
int rc;
bool ok;
if (part_passwd == NULL) {
DEBUG(10,("No password set - DISALLOWING access\n"));
@ -71,18 +72,19 @@ static bool smb_pwd_check_ntlmv1(TALLOC_CTX *mem_ctx,
DEBUGADD(100,("Value from encryption was |\n"));
dump_data(100, p24, 24);
#endif
if (memcmp(p24, nt_response->data, 24) == 0) {
if (user_sess_key != NULL) {
*user_sess_key = data_blob_talloc(mem_ctx, NULL, 16);
if (user_sess_key->data == NULL) {
DBG_ERR("data_blob_talloc failed\n");
return false;
}
SMBsesskeygen_ntv1(part_passwd, user_sess_key->data);
ok = (memcmp(p24, nt_response->data, 24) == 0);
if (!ok) {
return false;
}
if (user_sess_key != NULL) {
*user_sess_key = data_blob_talloc(mem_ctx, NULL, 16);
if (user_sess_key->data == NULL) {
DBG_ERR("data_blob_talloc failed\n");
return false;
}
return true;
}
return false;
SMBsesskeygen_ntv1(part_passwd, user_sess_key->data);
}
return true;
}
/****************************************************************************