sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code

Fix error return path memory leaks in vampire code for creating users.

Browse Source 
Display an error if we can't create a posix account for the user
(e.g no add user/machine script was specified; bug #323).
(This used to be commit 0c35ba2cd65ff64c5db2b20d5528a0d486cba51e)
This commit is contained in:
Tim Potter 2003-09-10 06:58:41 +00:00
parent 51297321ba
commit 4059dfcca2
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/utils/net_rpc_samsync.c
View File

@ -428,9 +428,10 @@ static NTSTATUS fetch_account_info(uint32 rid, SAM_ACCOUNT_INFO *delta)
(delta->acb_info & ACB_DOMTRUST) ) {
pstrcpy(add_script, lp_addmachine_script());
} else {
*add_script = '\0';
DEBUG(1, ("Unknown user type: %s\n",
smbpasswd_encode_acb_info(delta->acb_info)));
nt_ret = NT_STATUS_UNSUCCESSFUL;
goto done;
}
if (*add_script) {
int add_ret;
@ -448,8 +449,11 @@ static NTSTATUS fetch_account_info(uint32 rid, SAM_ACCOUNT_INFO *delta)
}
/* try and find the possible unix account again */
if ( !(passwd = Get_Pwnam(account)) )
return NT_STATUS_NO_SUCH_USER;
if ( !(passwd = Get_Pwnam(account)) ) {
d_printf("Could not create posix account info for '%s'\n", account);
nt_ret = NT_STATUS_NO_SUCH_USER;
goto done;
}
}
@ -499,6 +503,7 @@ static NTSTATUS fetch_account_info(uint32 rid, SAM_ACCOUNT_INFO *delta)
pdb_get_username(sam_account)));
}
done:
pdb_free_sam(&sam_account);
return nt_ret;
}