sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

vfs_ceph_new: use low-level APIs for linkat

Browse Source 
Implement link operations using libcephfs' low-level APIs. Requires two
phase operation: resolve (by-lookup) reference to inode and then do the
actual (hard) link operation using parent dir-inode reference to the
locally-cached inode.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
(cherry picked from commit 9a70bd606728110ad91cab547a4e31350010bb68)
This commit is contained in:
Shachar Sharon 2024-06-20 22:46:52 +03:00 committed by Jule Anger
parent 2583b0e882
commit 405a93f07c
1 changed files with 48 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
source3/modules/vfs_ceph_new.c
View File

@ -944,6 +944,18 @@ static int vfs_ceph_ll_fallocate(const struct vfs_handle_struct *handle,
return ceph_ll_fallocate(cmount_of(handle), cfh->fh, mode, off, len);
}
static int vfs_ceph_ll_link(const struct vfs_handle_struct *handle,
const struct vfs_ceph_fh *dircfh,
const char *name,
const struct vfs_ceph_iref *iref)
{
return ceph_ll_link(cmount_of(handle),
iref->inode,
dircfh->iref.inode,
name,
dircfh->uperm);
}
/* Ceph Inode-refernce get/put wrappers */
static int vfs_ceph_iget(const struct vfs_handle_struct *handle,
uint64_t ino,
@ -2177,40 +2189,50 @@ out:
}
static int vfs_ceph_linkat(struct vfs_handle_struct *handle,
files_struct *srcfsp,
const struct smb_filename *old_smb_fname,
files_struct *dstfsp,
const struct smb_filename *new_smb_fname,
int flags)
files_struct *srcfsp,
const struct smb_filename *old_smb_fname,
files_struct *dstfsp,
const struct smb_filename *new_smb_fname,
int flags)
{
struct smb_filename *full_fname_old = NULL;
struct smb_filename *full_fname_new = NULL;
struct vfs_ceph_fh *src_dircfh = NULL;
struct vfs_ceph_fh *dst_dircfh = NULL;
struct vfs_ceph_iref iref = {0};
const char *name = old_smb_fname->base_name;
const char *newname = new_smb_fname->base_name;
int result = -1;
full_fname_old = full_path_from_dirfsp_atname(talloc_tos(),
srcfsp,
old_smb_fname);
if (full_fname_old == NULL) {
return -1;
}
full_fname_new = full_path_from_dirfsp_atname(talloc_tos(),
dstfsp,
new_smb_fname);
if (full_fname_new == NULL) {
TALLOC_FREE(full_fname_old);
/* Prevent special linkat modes until it is required by VFS layer */
if (flags & (AT_EMPTY_PATH | AT_SYMLINK_FOLLOW)) {
errno = ENOTSUP;
return -1;
}
DBG_DEBUG("[CEPH] link(%p, %s, %s)\n", handle,
full_fname_old->base_name,
full_fname_new->base_name);
DBG_DEBUG("[CEPH] link(%p, %s, %s)\n", handle, name, newname);
result = ceph_link(cmount_of(handle),
full_fname_old->base_name,
full_fname_new->base_name);
result = vfs_ceph_fetch_fh(handle, srcfsp, &src_dircfh);
if (result != 0) {
goto out;
}
result = vfs_ceph_fetch_fh(handle, dstfsp, &dst_dircfh);
if (result != 0) {
goto out;
}
result = vfs_ceph_ll_lookupat(handle, src_dircfh, name, &iref);
if (result != 0) {
goto out;
}
result = vfs_ceph_ll_link(handle, dst_dircfh, newname, &iref);
if (result != 0) {
goto out;
}
vfs_ceph_iput(handle, &iref);
out:
DBG_DEBUG("[CEPH] link(...) = %d\n", result);
TALLOC_FREE(full_fname_old);
TALLOC_FREE(full_fname_new);
return status_code(result);
}