sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

lib: Fix a use-after-free in "net vfs getntacl"

Browse Source 
Don't hang "sd" off "fsp", which is free'ed before printing

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Jan 12 16:41:07 UTC 2023 on sn-devel-184
This commit is contained in:
Volker Lendecke 2023-01-12 12:00:26 +01:00 committed by Ralph Boehme
parent d278fe4a84
commit 425aaf6f7e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/utils/net_vfs.c
View File

@ -276,7 +276,7 @@ static int net_vfs_get_ntacl(struct net_context *net,
status = SMB_VFS_FGET_NT_ACL(fsp,
SECINFO_OWNER|SECINFO_GROUP|SECINFO_DACL,
fsp,
talloc_tos(),
&sd);
if (!NT_STATUS_IS_OK(status)) {
DBG_ERR("SMB_VFS_FGET_NT_ACL [%s] failed: %s\n",
@ -296,6 +296,8 @@ static int net_vfs_get_ntacl(struct net_context *net,
rc = 0;
done:
TALLOC_FREE(sd);
if (fsp != NULL) {
status = close_file_free(NULL, &fsp, NORMAL_CLOSE);
if (!NT_STATUS_IS_OK(status)) {